[
https://issues.apache.org/jira/browse/PHOENIX-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated PHOENIX-123:
-------------------------------------------
Attachment: Phoenix-123.patch
Some code removal. Rest looks good. Seen that you are now passing the
maxLength in the toObject() itself. And recreating the array incase of CHAR
and getBytesSize is null. So removal of rewriteByteArray makes sense.
But you don't need the array serialization header also? Is it because we are
not going to have any special serailzation for fixed arrays? rest looks good
to me.
> Fixed with array should not write any footer
> --------------------------------------------
>
> Key: PHOENIX-123
> URL: https://issues.apache.org/jira/browse/PHOENIX-123
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: James Taylor
> Fix For: 3.0.0
>
> Attachments: Phoenix-123.patch, arrayLength.patch
>
>
> Fixed length arrays should not write any footer, as it might throw off the
> byte comparison. For example, if comparing two arrays of different lengths,
> the longer array would begin to compare its elements against the footer of
> the shorter array. If the footer happened to be bigger (bytes-wise) for the
> shorter array, it would incorrectly evaluate to being bigger.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
