[ 
https://issues.apache.org/jira/browse/PHOENIX-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925963#comment-13925963
 ] 

ramkrishna.s.vasudevan commented on PHOENIX-123:
------------------------------------------------

One thing is after this patch the toBytes gets called in two places.  One 
during the compilation phase and other during the execute() phase through 
coerceBytes.  Will that be costly?
Or should we remove the toBytes call during compilation?


> Fixed with array should not write any footer
> --------------------------------------------
>
>                 Key: PHOENIX-123
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-123
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: James Taylor
>             Fix For: 3.0.0
>
>         Attachments: Phoenix-123.patch, arrayLength.patch
>
>
> Fixed length arrays should not write any footer, as it might throw off the 
> byte comparison. For example, if comparing two arrays of different lengths, 
> the longer array would begin to compare its elements against the footer of 
> the shorter array. If the footer happened to be bigger (bytes-wise) for the 
> shorter array, it would incorrectly evaluate to being bigger.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to