[ 
https://issues.apache.org/jira/browse/PHOENIX-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926268#comment-13926268
 ] 

James Taylor commented on PHOENIX-130:
--------------------------------------

Thanks, [~gabriel.reid]. For the most part just moving files around, right? 
Plus the maven changes. What's the issue with 
.WhereCompilerTest#testToNumberFilterWithPatternParam, as it seems to pass fine 
now? [~jeffreyz] - what do you think? If we wanted to take it for 3.0/4.0, 
would the same patch apply to both code lines? [~mujtabachohan]  - what do you 
think? Would this entail work on your end?

> Separate execution of slow (integration) tests from fast unit tests
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-130
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-130
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>         Attachments: PHOENIX-130.patch
>
>
> The current collection of automated unit tests and integration tests takes a 
> significant amount of time to run (somewhere in the neighborhood of 90 
> minutes on my machine).
> I’d like to propose that the automated tests are split up into two groups:
> * unit tests, which don’t make use of a running HBase and run quickly, and 
> will be run within the maven test phase
> * integration tests, which do make use of a running HBase and run more 
> slowly, and will be run within the maven integration-test phase
> This approach has the advantage that all fast-running unit tests will be run 
> before the integration tests, so if there is a minor issue the build will 
> fail-fast instead of first running long-running integration tests before 
> failing. It also makes it possible to quickly and regularly run “mvn test” 
> during development to run all unit tests in a matter of seconds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to