Github user yaise commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/15#discussion_r10463772
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -1251,7 +1251,7 @@ protected PhoenixConnection 
addColumnsIfNotExists(PhoenixConnection oldMetaConne
         public void init(String url, Properties props) throws SQLException {
    --- End diff --
    
    This init method is exactly the same here and 
ConnectionlessQueryServicesImpl.java. 
    should be refactored, probably into static method somewhere as it doesn't 
affect the state of either classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to