[
https://issues.apache.org/jira/browse/PHOENIX-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930531#comment-13930531
]
ASF GitHub Bot commented on PHOENIX-831:
----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/15#discussion_r10481425
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
@@ -119,7 +116,36 @@ private static Properties newPropsWithSCN(long scn,
Properties props) {
props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB,
Long.toString(scn));
return props;
}
-
--- End diff --
Yes, +1 on using a new util method in place of all "new
Properties(Properties)" calls. I don't want to special case stuff for a certain
property, as this will just come back to bite us again. Would you mind
reworking your pull based on that and I'll commit it after that?
> First Connection to Phoenix blows up if it is tenant specific
> -------------------------------------------------------------
>
> Key: PHOENIX-831
> URL: https://issues.apache.org/jira/browse/PHOENIX-831
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Somesh Sasalatti
>
> Driver driver = DriverManager.getDriver(url);
> Properties props = new Properties();
> final String tenantId = "00Dxx0000001234";
> props.put(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId);
> Connection connection = driver.connect(url, props);
> BOOM!
> I have pull request coming shortly
--
This message was sent by Atlassian JIRA
(v6.2#6252)
