[
https://issues.apache.org/jira/browse/PHOENIX-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931060#comment-13931060
]
James Taylor commented on PHOENIX-128:
--------------------------------------
One minor issue, in PArrayDataType, you have an early exit for maxLength==null,
but what if the type is being coerced for a fixed length type? Also, if the
sortOrder is different, you wouldn't want to exit early. In this case the
maxLength would be null. I think you'd want this which only returns if
{code}
if(maxLength == null && actualType.isBytesComparableWith(desiredType) &&
actualModifer == expectedModifier) {
return;
}
{code}
> Support coercion and descending sort order for ARRAY
> ----------------------------------------------------
>
> Key: PHOENIX-128
> URL: https://issues.apache.org/jira/browse/PHOENIX-128
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Fix For: 3.0.0
>
> Attachments: Phoenix-128_1.patch
>
>
> Now that our ARRAY types may be used in the primary key, we need to support
> descending sort order (i.e. inverting the bits). There are also holes in the
> support for coerce, as it's legitimate to coerce an array of BIGINT to an
> array of INTEGER for example.
> This can all be handled pretty easily in the PArrayDataType.coerceBytes()
> method.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
