Github user elilevine commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/16#discussion_r10621363
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/TenantSpecificTablesDMLTest.java
---
@@ -384,4 +384,17 @@ public void
testTenantTableCannotBeUsedInStatementsInNonMultitenantConnections()
conn.close();
}
}
+
+ @Test
+ public void testUpsertValuesUsingViewWithNoWhereClause() throws
Exception {
+ Connection conn =
nextConnection(PHOENIX_JDBC_TENANT_SPECIFIC_URL);
+ conn.setAutoCommit(true);
+ conn.createStatement().executeUpdate("upsert into " +
TENANT_TABLE_NAME_NO_TENANT_TYPE_ID + " (id) values (0)");
+
+ ResultSet rs = conn.createStatement().executeQuery("select id from
" + TENANT_TABLE_NAME_NO_TENANT_TYPE_ID);
+ assertTrue(rs.next());
--- End diff --
@jtaylor-sfdc, with the null check in UpsertCompiler upsert no longer NPEs.
This test is now failing at this line, meaning this select does not return the
expected single row. Haven't had time to debug further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
