[ 
https://issues.apache.org/jira/browse/PHOENIX-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935550#comment-13935550
 ] 

ASF GitHub Bot commented on PHOENIX-841:
----------------------------------------

Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/16#discussion_r10624236
  
    --- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/end2end/TenantSpecificTablesDMLTest.java
 ---
    @@ -384,4 +384,17 @@ public void 
testTenantTableCannotBeUsedInStatementsInNonMultitenantConnections()
                 conn.close();
             }
         }
    +    
    +   @Test
    +   public void testUpsertValuesUsingViewWithNoWhereClause() throws 
Exception {
    +           Connection conn = 
nextConnection(PHOENIX_JDBC_TENANT_SPECIFIC_URL);
    +           conn.setAutoCommit(true);
    +           conn.createStatement().executeUpdate("upsert into " + 
TENANT_TABLE_NAME_NO_TENANT_TYPE_ID + " (id) values (0)");
    +           
    +        ResultSet rs = conn.createStatement().executeQuery("select id from 
" + TENANT_TABLE_NAME_NO_TENANT_TYPE_ID);
    +        assertTrue(rs.next());
    --- End diff --
    
    Nice!  Thanks, James.


> Upserting into tenant-specific view with no where clause fails with an NPE
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-841
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-841
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Eli Levine
>             Fix For: 3.0.0
>
>         Attachments: PHOENIX-841_2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to