[
https://issues.apache.org/jira/browse/PHOENIX-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Reid updated PHOENIX-896:
---------------------------------
Attachment: PHOENIX-896.patch
Patch to introduce the use of commons-cli for command-line parsing instead of
the custom code. Patch also includes a bit of cleanup of the CSVCommonsLoader.
A small backwards-incompatibility is introduced by this patch, in that the CSV
field separator, quote character, and escape character are now supplied as
separate parameters instead of a single parameter. This is more in-line with
typical command-line parameter handling, but will not be backwards compatible
with the current behaviour.
> Improve cmdline parsing of psql (PhoenixRuntime)
> ------------------------------------------------
>
> Key: PHOENIX-896
> URL: https://issues.apache.org/jira/browse/PHOENIX-896
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Gabriel Reid
> Attachments: PHOENIX-896.patch
>
>
> PhoenixRuntime (the class that is run via the "psql" command) does its own
> custom command-line parameter parsing, which has a number of limitations. One
> of the biggest issues is that it depends on the ordering of named parameters
> vs unnamed (i.e. file parameters), and starts performing actions as part of
> the command-line parameter parsing. This can lead to some files being
> run/imported, and then the tool stopping with an error due to an unexpected
> command-line parameter.
> An additional (but probably less important) issue is that the current
> parameter parsing is difficult to debug and test (there are currently no
> automated tests).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
