Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/27#discussion_r11761273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -553,4 +556,24 @@ public static short getMaxKeySeq(PTable table) {
}
return (short)(table.getPKColumns().size() - offset);
}
+
+ public static String getEscapedFullColumnName(String fullColumnName) {
+ int index = fullColumnName.indexOf(QueryConstants.NAME_SEPARATOR);
+ if (index < 0) {
+ return getEscapedArgument(fullColumnName);
+ }
+ String columnFamily = fullColumnName.substring(0,index);
+ String columnName = fullColumnName.substring(index+1);
+ return ESCAPE_CHARACTER + columnFamily + ESCAPE_CHARACTER +
QueryConstants.NAME_SEPARATOR + getEscapedArgument(columnName) ;
--- End diff --
Any reason you're not do the following instead:
return getEscapedArgument(columnFamily) + QueryConstants.NAME_SEPARATOR
+ getEscapedArgument(columnName) ;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
