[
https://issues.apache.org/jira/browse/PHOENIX-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976241#comment-13976241
]
James Taylor commented on PHOENIX-848:
--------------------------------------
Wow, thanks [~jeffreyz]. Question on and perhaps an alternative to (1). If we
could roll out a Phoenix release that would run on both 0.96 and 0.98 *without*
requiring changes to 0.96, that would be preferable. I think (hope) it's
unlikely that there will be another 0.96 release, as it perhaps will be more
likely that vendors will just move to 0.98 as Hortonworks has. Plus the biggest
win for Phoenix would be to not require folks to upgrade to a newer 0.96
release, as once something is out on a cluster, there can be a certain
(justifiable) resistance to changing it.
Would it be possible to do the following (albeit more hacky fix) instead of
backporting HBase-9754?
- Add an interface to Phoenix for setting the read point
- Implement two different implementations: for 0.98 the implementation would be
a noop
- Have a factory method in our coprocessor code that would select the correct
implementation based on the HBase version
- Add back the MultiVersionConsistencyControl.setReadPoint calls (going through
our new interface) back to 4.0 in the same place they're in 3.0.
Then we could incorporate your patch in addition to this and everything (in
theory :-) ) would work.
> Enable HBase 0.96 on Master & 4.0 branch
> ----------------------------------------
>
> Key: PHOENIX-848
> URL: https://issues.apache.org/jira/browse/PHOENIX-848
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Jeffrey Zhong
> Attachments: EnableOnHBase0.96.patch
>
>
> Currently Master & 4.0 branch can support HBase0.98 & Trunk. While there are
> basically two areas which make the code can't work on hbase0.96 such as HLog
> & region row lock change(MultiVersionConsistencyControl.setThreadReadPoint is
> removed from hbase0.98+)
> It seems better that we could create a layer to abstract out those hbase
> differences(as the differences aren't much) so Phoenix can also run on
> HBase0.96.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
