[
https://issues.apache.org/jira/browse/PHOENIX-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982682#comment-13982682
]
ASF GitHub Bot commented on PHOENIX-951:
----------------------------------------
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/32#issuecomment-41515091
+1. Looks great, @maryannxue. One minor question about an exception case.
Thanks so much for the contributions. Would you have time to review the join
documentation for any necessary updates?
> Don't push LIMIT as PageFilter for joins
> ----------------------------------------
>
> Key: PHOENIX-951
> URL: https://issues.apache.org/jira/browse/PHOENIX-951
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0
> Reporter: James Taylor
> Assignee: Maryann Xue
> Priority: Minor
>
> When a join has a limit, you can't push the limit through a PageFilter since
> you might not get a match when you join the LHS to the RHS. I think ideally
> you'd want to push the LIMIT to the ScanRegionObserver (or
> GroupedAggregateRegionObserver) and then stop the inner scan when the limit
> is reached. There's a similar optimize for a GROUP BY that has a LIMIT with
> no ORDER BY.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
