[ 
https://issues.apache.org/jira/browse/PHOENIX-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989325#comment-13989325
 ] 

Gabriel Reid commented on PHOENIX-966:
--------------------------------------

Thanks for taking a look [~jamestaylor]. 

{quote}Would you mind updating the documentation on our website too sometime 
over the next couple of weeks?{quote}

Yes, for sure, I'll get on that as soon as this is committed.

{quote}One corner case I just thought of is stats collection (which is really 
just getting the min and max key of an HTable at this point). See 
StatsManagerImpl.updateStats(TableRef tableRef) which uses HBase APIs 
directly.{quote}

Thanks for pointing this one out. Tracing through the code, it appears that 
this method (and other things from StatsManager in general) only get called 
from a context that is running within a PhoenixContextExecutor call. Just to be 
sure, was there a specific spot that you were thinking might be an issue?


> Phoenix needs to be on the main classpath of SQL tools
> ------------------------------------------------------
>
>                 Key: PHOENIX-966
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-966
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>         Attachments: PHOENIX-966a.patch, PHOENIX-966b-3.0.patch, 
> PHOENIX-966b-4.0.patch
>
>
> The Phoenix client jar currently needs to be put on the boot classpath of 
> external SQL tools in order to function correctly, while most JDBC drivers do 
> not have this requirement.
> For example, in SQuirreL there is an option to provide the path to the JDBC 
> driver jar file when defining a JDBC driver. This approach doesn't work with 
> Phoenix due to it dependence on loading classes and the hbase-default.xml 
> file via the context classloader.
> For installations of external tools where users don't have the 
> rights/abilities/knowledge necessary to add an external jar file to the boot 
> classpath, this causes a genuine issue for using Phoenix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to