[ 
https://issues.apache.org/jira/browse/PHOENIX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000101#comment-14000101
 ] 

James Taylor commented on PHOENIX-19:
-------------------------------------

Thanks so much for the contributions, [~anilgupta84]. Yes, we'd definitely like 
to get this into 3.1/4.1 release. Need to make sure the unit tests pass, 
though. Couple of minor comments:
In ConnectionQueryServicesImpl.java
- use the static constants HBASE_CLIENT_KEYTAB and HBASE_CLIENT_PRINCIPAL for 
the keytab and principal config params get
- do a config.get(HBASE_CLIENT_KEYTAB) and config.get(HBASE_CLIENT_PRINCIPAL) 
before the if statement
- just compare against clientKeyTable != null && clientPrincipal != null for 
the if statement

Try doing a mvn clean install to get around the tests stopping at 
TestEndToEndCoveredIndexing. Failing that, dial down the parallelization we do 
by running the tests like this: mvn install -DnumForkedIT=1. For 3.0, we've 
disabled parallelization, so this wouldn't be a factor.

Will your master patch apply to the 4.0 branch as well?






> Enhance JDBC connection of Phoenix to support connecting to a Secure HBase 
> cluster.
> -----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-19
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-19
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Anil Gupta
>              Labels: hbase, jdbc, secure
>             Fix For: 3.0.0
>
>         Attachments: SecureClusterConnectTest.java, 
> phoenix-19-master-apache.patch, phoenix-19.patch
>
>
> This is being moved from github 
> https://github.com/forcedotcom/phoenix/issues/550 to JIRA.
> As per my discussion with James Taylor over here 
> https://groups.google.com/forum/#!searchin/phoenix-hbase-user/secure$20cluster/phoenix-hbase-user/XHg2wXK4Hqo/qVTm92WLxUkJ
> and some other email exchanges. This ticket is to enhance the JDBC driver of 
> phoenix so that user can pass keytab and principal to connect to a secure 
> cluster.
> As per our discussion over email, could you please outline the changes 
> required to make this enhancement?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to