[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922389#action_12922389
]
Alan Gates commented on PIG-1675:
---------------------------------
Feedback from testpatch.sh
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 8 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec]
[exec]
[exec]
[exec]
======================================================================
[exec]
======================================================================
[exec] Finished build.
[exec]
======================================================================
[exec]
======================================================================
[exec]
[exec]
{code}
I'll attach the file from findbugs. It's complaining about cleanup of
resources in your change.
> Suggest to allow PigServer can register pig script from InputStream
> -------------------------------------------------------------------
>
> Key: PIG-1675
> URL: https://issues.apache.org/jira/browse/PIG-1675
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Fix For: 0.9.0
>
> Attachments: PIG_1675.patch, PIG_1675_2.patch
>
>
> Currently, Pig only allow users to register script from file. Although it
> satisfy most people's requirements, sometimes people hope to build pig script
> dynamically using code, then they need to create temp file for the script
> they build. So here I suggest to allow PigServer be able to register pig
> script from InputStream.
> InputStream is a more general type than File, pig script can been from file
> (FileInputStream)
> or from in-memory (ByteArrayInputStream) even it can been from remote
> machines (SocketInputStream)
> Here's a blog which explains why using InputStream is better than using File
> in interface http://java.dzone.com/articles/using-files-your-interfaces-0
> So I suggest to add the following 4 methods in PigServer:
> {code}
> public void registerScript(InputStream in) throws IOException
> public void registerScript(InputStream in, Map<String,String> params) throws
> IOException
> public void registerScript(InputStream in, List<String> paramsFiles) throws
> IOException
> public void registerScript(InputStream in, Map<String,String>
> params,List<String> paramsFiles) throws IOException
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
