[
https://issues.apache.org/jira/browse/PIG-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970348#action_12970348
]
Ashutosh Chauhan commented on PIG-1755:
---------------------------------------
bq. It occurred to me after posting this patch that it would be better to use
the DataType enums instead of classes
Are you referring to types defined in DataType.java ? Currently, they are byte.
Changing them to enums instead may not be desirable since while writing out
tuples we first write the type(which is a byte). byte is efficient
representation there but if we change to enums, enums will get serialized and
will take more then a byte. I/O cost resulting from that will be order of
magnitude worse then CPU savings we might get by having enums.
> Clean up duplicated code in Physical Operators
> ----------------------------------------------
>
> Key: PIG-1755
> URL: https://issues.apache.org/jira/browse/PIG-1755
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: PIG-1755.patch
>
>
> A lot of the getNext() implementations in PhysicalOperators is copy-pasted,
> with only the method signatures and casts changing.
> Shorter code leads to less bugs and is easier to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
