-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/269/
-----------------------------------------------------------
Review request for pig and Xuefu Zhang.
Summary
-------
The following script produce wrong result:
a = load '1.txt' as (a0:bag{t:tuple(i0:int, i1:int)});
b = foreach a generate flatten(a0) as (b0, b1), flatten(a0) as (b2, b3);
c = filter b by b0>b2;
dump c;
1.txt:
{(1,2),(2,3)}
Expected result:
(2,3,1,2)
We get nothing.
This addresses bug PIG-1785.
https://issues.apache.org/jira/browse/PIG-1785
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/DuplicateForEachColumnRewrite.java
1055137
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/ImplicitSplitInserter.java
1055137
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/optimizer/PlanOptimizer.java
1055137
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/optimizer/Rule.java
1055137
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1055137
Diff: https://reviews.apache.org/r/269/diff
Testing
-------
Test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 478 release
audit warnings (more than the trunk's current 476 warnings).
No new files added. Ignore release audit warnings.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
