-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/314/
-----------------------------------------------------------

Review request for pig and thejas.


Summary
-------

PIG-1786-1.patch is based on LogicalPlanMigrationVistor. After new parser is 
done, we need to move it completely to new logical plan. I want to fix it like 
this for now to unblock other issues in semantic cleanup.


This addresses bug PIG-1786.
    https://issues.apache.org/jira/browse/PIG-1786


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigServer.java 
1058308 
  
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOForEach.java
 1058308 
  
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOGenerate.java
 1058308 
  
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java
 1058308 

Diff: https://reviews.apache.org/r/314/diff


Testing
-------

Test-patch:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 479 release 
audit warnings (more than the trunk's current 478 warnings).

No new file added, ignore "release audit".

Unit-test:
    all pass


Thanks,

Daniel

Reply via email to