----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/#review122 -----------------------------------------------------------
Ship it! Interesting! - Julien On 2011-01-14 14:18:18, Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/320/ > ----------------------------------------------------------- > > (Updated 2011-01-14 14:18:18) > > > Review request for pig and Julien Le Dem. > > > Summary > ------- > > Current Pig exception handling does not treat Jython exceptions differently > from general RuntimeExceptions. We need to put Jython exceptions in a > separate class and output better error messages. > > > This addresses bug PIG-1801. > https://issues.apache.org/jira/browse/PIG-1801 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/Pig.java > 1059179 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/ScriptEngine.java > 1059179 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java > 1059179 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestScriptLanguage.java > 1059179 > > Diff: https://reviews.apache.org/r/320/diff > > > Testing > ------- > > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > > Thanks, > > Richard > >
