[ 
https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003580#comment-13003580
 ] 

Thejas M Nair commented on PIG-1884:
------------------------------------

bq. Alan specifically emailed me asking to stop reindenting things cause it 
made patches hard to read
Because of the indentation issues, the code was very hard to read ! There was 
only a one line change other than indentation change in TestHBaseStorage, so I 
guess it was not that hard to review the patch this time.


bq. What's the change to start mini hbase cluster?
Sorry, my comment was incomplete . The change to start mini hbase cluster was 
only in TestJobSubmission.java .

I am creating a new patch to fix the related unit test failures in 0.8, as this 
patch has merge issues in 0.8. I will submit that after running unit tests on 
0.8.



> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
>                 Key: PIG-1884
>                 URL: https://issues.apache.org/jira/browse/PIG-1884
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Thejas M Nair
>             Fix For: 0.9.0
>
>         Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop 
> job. This change cause TestExampleGenerator fail. The reason is 
> ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We 
> never get to this point before PIG-1680.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to