-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/508/
-----------------------------------------------------------
Review request for pig and Richard Ding.
Summary
-------
Currently user can not register pig jars with globing.
For example following register script will fail.
register /etc/jars/*.jar
It will be great if we can support such globing for registering jars.
Release notes:
We allow globbing in register statement. User can use "*" to denote a globbing,
eg:
register key*.jar
register /home/jarpath/key*.jar
register jars/key*.jar
The path can be absolute path or relative path start with working directory.
Note globbing does not further search in classpath as non-globbing case does,
eg:
"register key1234.jar" works if key1234.jar in classpath, but not in working
directory, however,
"register key*.jar" will not locate key1234.jar in this case.
This addresses bug PIG-1566.
https://issues.apache.org/jira/browse/PIG-1566
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigServer.java
1081219
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java
1081219
Diff: https://reviews.apache.org/r/508/diff
Testing
-------
Test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
