[ 
https://issues.apache.org/jira/browse/PIG-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009221#comment-13009221
 ] 

Xuefu Zhang commented on PIG-1925:
----------------------------------

Patch also includes fixes for default error messages generated by Antlr, "no 
viable alternative at input ...". Now the error messages are show as:

1. for lexer

grunt> A = load ^ as (u, v, w);
line 1:9 Unexpected character '^'
2011-03-21 10:21:04,147 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 
0: line 1:9 Unexpected character '^'

2. for parser

grunt> A = laod 'x' as (u, v, w);
2011-03-21 10:21:53,517 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 
0: line 1:0 Unexpected symbol at or near ['A']

(Please not that in the above case, parser isn't able to identify "load" is 
misspelled, but it's not what this fix is about. That case is tracked in a 
different JIRA.)



> Parser error message doesn't show location of the error or show it as Line 0:0
> ------------------------------------------------------------------------------
>
>                 Key: PIG-1925
>                 URL: https://issues.apache.org/jira/browse/PIG-1925
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-1925.patch
>
>
> When Parser emits an error from one of the tree parsers (like AST validation 
> or plan generation), Line number is missing or printed as Line 0:0. Further 
> investigation shows that Antlr 3.2 isn't able to report the correct line 
> number and line offset. We need to address it in Pig code.
> The following is an example.
> grunt> A = load 'x' as (u, v, u, w);
> 2011-03-21 10:04:44,486 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 
> 0: Duplicated alias in schema: u
> It's desirable to have line number/offset in such kind of error messages.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to