[
https://issues.apache.org/jira/browse/PIG-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013779#comment-13013779
]
Eric Yang commented on PIG-1946:
--------------------------------
An alternative is to modify the syntax like:
{noformat}
STORE result INTO 'hbase://foo' USING
org.apache.pig.backend.hadoop.hbase.HBaseStorage(
'info:first_name info:last_name');
{noformat}
Eliminate comma from the syntax completely. It may have some readability issue
with this approach.
Having that said, the problem can be solved in more user friendly manner by
improving the parser to filter prefix and suffix of comma, and comma only cases.
Maybe this issue can be defined more accurately with: "Improve syntax parsing
for HBaseStorage constructor".
> HBaseStorage constructor syntax is error prone
> ----------------------------------------------
>
> Key: PIG-1946
> URL: https://issues.apache.org/jira/browse/PIG-1946
> Project: Pig
> Issue Type: Improvement
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> Using {{HBaseStorage}} like so seems like a reasonable thing to do, but it
> will yield unexpected results:
> {code}
> STORE result INTO 'hbase://foo' USING
> org.apache.pig.backend.hadoop.hbase.HBaseStorage(
> 'info:first_name, info:last_name');
> {code}
> The problem us that a column named {{info:first_name,}} will be created, with
> the trailing comma included. I've had numerous developers get tripped up on
> this issue since everywhere else in Pig variables are separated by commas, so
> I propose we fix it.
> I propose we trim leading/trailing commas from column names, but I'm open to
> other ideas.
> Also should we accept column names that are comman-delimited without spaces?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
