[
https://issues.apache.org/jira/browse/PIG-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019985#comment-13019985
]
Xuefu Zhang commented on PIG-1987:
----------------------------------
For patch PIG-1987.patch, it appears to me that dryrun() method in
QueryParserDriver has nothing to do with the what QueryParserDriver is doing.
Right now there is loop in calling stack: Main -> QueryParserDriver ->
DryrunParser -> QueryParserDriver, which can be made better by moving dryrun()
method from QueryParserDriver to DryrunDriver itself. With that, the class
reference should be Main -> DryrunParser ->QueryParserDriver, resulting a
cleaner design.
I can review again if the suggested change makes sense.
> -dryrun does not work with set
> ------------------------------
>
> Key: PIG-1987
> URL: https://issues.apache.org/jira/browse/PIG-1987
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1987.patch
>
>
> The following script works
> {code}
> set default_parallel 10;
> import 'scripts/macro1.pig';
> import 'scripts/macro2.pig';
> wlogs = load 'clicks' as (url, pageid, timestamp);
> good = spam_filter(wlogs, url);
> {code}
> But if -dryrun is added to the command line it returns the error:
> {code}
> ERROR 1200: <file scripts/book.pig.substituted, line 1, column 0> Syntax
> error, unexpected symbol at or near 'set'
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
