----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/587/#review461 -----------------------------------------------------------
Ship it! +1 - thejas On 2011-04-13 00:11:37, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/587/ > ----------------------------------------------------------- > > (Updated 2011-04-13 00:11:37) > > > Review request for pig and thejas. > > > Summary > ------- > > See PIG-1979 > > > This addresses bug PIG-1979. > https://issues.apache.org/jira/browse/PIG-1979 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/branches/branch-0.8/src/org/apache/pig/newplan/logical/expression/DereferenceExpression.java > 1091122 > > http://svn.apache.org/repos/asf/pig/branches/branch-0.8/test/org/apache/pig/test/TestEvalPipeline2.java > 1091122 > > Diff: https://reviews.apache.org/r/587/diff > > > Testing > ------- > > Test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > Unit-test: > all pass > > > Thanks, > > Daniel > >
