----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/624/#review499 -----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/LineageFindRelVisitor.java <https://reviews.apache.org/r/624/#comment1029> If there are multiple group-by columns, the group column will be a tuple. This will associate the load function only to the tuple and not the uids of the columns within the tuple. Need to associated load function to inner-uids as well like its done in mapMatchLoadFuncToUid - thejas On 2011-04-19 21:20:10, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/624/ > ----------------------------------------------------------- > > (Updated 2011-04-19 21:20:10) > > > Review request for pig and thejas. > > > Summary > ------- > > See PIG-1910 > > > This addresses bug PIG-1910. > https://issues.apache.org/jira/browse/PIG-1910 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/DereferenceExpression.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ExpToPhyTranslationVisitor.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ProjectExpression.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOCogroup.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ColumnAliasConversionVisitor.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/LineageFindRelVisitor.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/UDFFinder.java > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParserDriver.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPlanGeneration.java > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java > 1095145 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/Util.java > 1095145 > > Diff: https://reviews.apache.org/r/624/diff > > > Testing > ------- > > Test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 12 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > Unit test: > all pass > > > Thanks, > > Daniel > >
