[ 
https://issues.apache.org/jira/browse/PIG-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023253#comment-13023253
 ] 

Richard Ding commented on PIG-2005:
-----------------------------------

Patch-test result:

{code}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
{code}

Unit tests pass.

> Discrepancy in the way dry run handles semicolon in macro definition
> --------------------------------------------------------------------
>
>                 Key: PIG-2005
>                 URL: https://issues.apache.org/jira/browse/PIG-2005
>             Project: Pig
>          Issue Type: Bug
>          Components: grunt
>    Affects Versions: 0.9.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.9.0
>
>         Attachments: PIG-2005_1.patch
>
>
> Macro definition requires a semicolon to mark the end. For example:
> {code}
> define mymacro(x) returns y {... ...};
> {code}
> But invoked through command line, the macro definitions without semicolon 
> also work except in the case of dryrun. This discrepancy is due to 
> GruntParser automatic appending a semicolon to Pig statements if semicolon is 
> absent at the end. Dryrun GruntParser should do the same.   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to