[
https://issues.apache.org/jira/browse/PIG-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026727#comment-13026727
]
jirapos...@reviews.apache.org commented on PIG-1989:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/673/#review606
-----------------------------------------------------------
Ship it!
+1
- thejas
On 2011-04-28 20:56:30, Daniel Dai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/673/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-28 20:56:30)
bq.
bq.
bq. Review request for pig and thejas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See PIG-1989
bq.
bq.
bq. This addresses bug PIG-1989.
bq. https://issues.apache.org/jira/browse/PIG-1989
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
1097304
bq.
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPOCast.java
1097304
bq.
bq. Diff: https://reviews.apache.org/r/673/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test-patch:
bq. [exec] +1 overall.
bq. [exec]
bq. [exec] +1 @author. The patch does not contain any @author tags.
bq. [exec]
bq. [exec] +1 tests included. The patch appears to include 3 new or
modified tests.
bq. [exec]
bq. [exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
bq. [exec]
bq. [exec] +1 javac. The applied patch does not increase the total
number of javac compiler warnings.
bq. [exec]
bq. [exec] +1 findbugs. The patch does not introduce any new
Findbugs warnings.
bq. [exec]
bq. [exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
bq.
bq. Unit test:
bq. all pass
bq.
bq.
bq. Thanks,
bq.
bq. Daniel
bq.
bq.
> complex type casting should return null on casting failure
> -----------------------------------------------------------
>
> Key: PIG-1989
> URL: https://issues.apache.org/jira/browse/PIG-1989
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-1989-1.patch, PIG-1989-2.patch
>
>
> When casting fails for complex objects, pig is currently returning un-casted
> object if the cast fails.
> It should return null instead. That is consistent with the behavior when
> casting to other basic types.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
