[ https://issues.apache.org/jira/browse/PIG-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033172#comment-13033172 ]
jirapos...@reviews.apache.org commented on PIG-2067: ---------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/743/ ----------------------------------------------------------- (Updated 2011-05-13 18:13:38.714903) Review request for pig and Richard Ding. Summary ------- See PIG-2067 This addresses bug PIG-2067. https://issues.apache.org/jira/browse/PIG-2067 Diffs ----- http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ProjectExpression.java 1102169 http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/UserFuncExpression.java 1102169 http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/LogicalExpressionSimplifier.java 1102169 http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestFilterSimplification.java 1102169 Diff: https://reviews.apache.org/r/743/diff Testing (updated) ------- Test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 562 release audit warnings (more than the trunk's current 561 warnings). Ignore release audit warning since no new file is added. Unit test: all pass End-to-end test: all pass Thanks, Daniel > FilterLogicExpressionSimplifier removed some branches in some cases > ------------------------------------------------------------------- > > Key: PIG-2067 > URL: https://issues.apache.org/jira/browse/PIG-2067 > Project: Pig > Issue Type: Bug > Components: impl > Affects Versions: 0.8.1, 0.9.0 > Reporter: Daniel Dai > Assignee: Daniel Dai > Fix For: 0.8.1, 0.9.0 > > Attachments: PIG-2067-1-0.8.patch, PIG-2067-1.patch > > > The following script produce wrong result: > {code} > A = load 'a.dat' as (cookie); > B = load 'b.dat' as (cookie); > C = cogroup A by cookie, B by cookie; > E = filter C by COUNT(B)>0 AND COUNT(A)>0; > explain E; > {code} > a.dat: > 1 1 > 2 2 > 3 3 > 4 4 > 5 5 > 6 6 > 7 7 > b.dat: > 3 3 > 4 4 > 5 5 > 6 6 > 7 7 > 8 8 > Expected output: > (3,{(3)},{(3)}) > (4,{(4)},{(4)}) > (5,{(5)},{(5)}) > (6,{(6)},{(6)}) > (7,{(7)},{(7)}) > We get: > (3,{(3)},{(3)}) > (4,{(4)},{(4)}) > (5,{(5)},{(5)}) > (6,{(6)},{(6)}) > (7,{(7)},{(7)}) > (8,{},{(8)}) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira