[
https://issues.apache.org/jira/browse/PIG-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044969#comment-13044969
]
Bill Graham commented on PIG-1946:
----------------------------------
I was thinking any combination of comma and space would always be used to
delimit by default. If -constructorDelimiter is specified we can either say:
a.) same logic but sub comma out for -constructorDelimiter; or b.) Only use
-constructorDelimiter as the delimiter in which case spaces would be part of
the column descriptor if found.
I lean towards a.) but if allowing people to use spaces in column names is
valid, then we should do b.).
Thoughts?
> HBaseStorage constructor syntax is error prone
> ----------------------------------------------
>
> Key: PIG-1946
> URL: https://issues.apache.org/jira/browse/PIG-1946
> Project: Pig
> Issue Type: Improvement
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.10
>
> Attachments: PIG-1946_1.patch
>
>
> Using {{HBaseStorage}} like so seems like a reasonable thing to do, but it
> will yield unexpected results:
> {code}
> STORE result INTO 'hbase://foo' USING
> org.apache.pig.backend.hadoop.hbase.HBaseStorage(
> 'info:first_name, info:last_name');
> {code}
> The problem us that a column named {{info:first_name,}} will be created, with
> the trailing comma included. I've had numerous developers get tripped up on
> this issue since everywhere else in Pig variables are separated by commas, so
> I propose we fix it.
> I propose we trim leading/trailing commas from column names, but I'm open to
> other ideas.
> Also should we accept column names that are comman-delimited without spaces?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
