[ 
https://issues.apache.org/jira/browse/PIG-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062664#comment-13062664
 ] 

Ken Goodhope commented on PIG-1890:
-----------------------------------

Removing the blocker for PIG-2153.  Turns out the problem, as first asserted, 
was in AvroStorage.  The new logical plan must handle implicit wrapping tuples 
differently than used to be the case.  In order to make this work, I removed 
the wrapping tuple from the schema produced by getSchema.  getNext still 
returns its result in the wrapping tuple.  I also had to modify putNext, to 
expect a piq schema without the implicit wrapping tuple.

> Fix piggybank unit test TestAvroStorage
> ---------------------------------------
>
>                 Key: PIG-1890
>                 URL: https://issues.apache.org/jira/browse/PIG-1890
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Jakob Homan
>         Attachments: PIG-1890-1.patch, PIG-1890-2.patch, PIG-1890-3.patch, 
> PIG-1890-4.patch, pig_setloc_avro.txt
>
>
> TestAvroStorage fail on trunk. There are two reasons:
> 1. After PIG-1680, we call LoadFunc.setLocation one more time.
> 2. The schema for AvroStorage seems to be wrong. For example, in first test 
> case testArrayDefault, the schema for "in" is set to "PIG_WRAPPER: (FIELD: 
> {PIG_WRAPPER: (ARRAY_ELEM: float)})". It seems PIG_WRAPPER is redundant. This 
> issue is hidden until PIG-1188 checked in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to