[
https://issues.apache.org/jira/browse/PIG-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065469#comment-13065469
]
Dmitriy V. Ryaboy commented on PIG-2114:
----------------------------------------
Thanks for contributing, good stuff in there.
Comments on the patch:
- "none existent" should be "non-existent"
- if you add the line "Object storeValue = t.get(i);", might as well reuse
storeValue in other places in this function rather than keep calling t.get
- the call setMaxVersions() is different from current behavior. We currently
only get the latest version, and don't have provisions for dealing with
multiple versions. As Bill pointed out, that also means scanMaxVersions
probably doesn't work
- this really needs tests for every new flag.
> Enhancements to PIG HBaseStorage Load & Store Func with extra scan
> configurations
> ---------------------------------------------------------------------------------
>
> Key: PIG-2114
> URL: https://issues.apache.org/jira/browse/PIG-2114
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Hariprasad Kuppuswamy
> Priority: Minor
> Labels: hbase, storage
> Fix For: 0.10
>
> Attachments:
> 0001-Enhancements-to-Pig-HBase-Load-Storage-function-as-l.patch
>
>
> - Added capability to specify scan based on timestamps (Hariprasad
> Kuppuswwamy)
> - Ability to specify number of versions to be fetched with current scan
> (Hariprasad Kuppuswwamy)
> - Configure the rowkey prefixes filter for the scan (Hariprasad Kuppuswwamy)
> - Added ability to omit nulls when dealing with hbase storage (Greg Bowyer)
> - Added ability to specify Put timestamps while insertion (Hariprasad
> Kuppuswamy)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
