[
https://issues.apache.org/jira/browse/PIG-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Graham updated PIG-1946:
-----------------------------
Attachment: PIG-1946_2.patch
Attaching a new patch with the changes suggested. I've created a new unit test
for speed, since the param testing for this bug doesn't require the mini
cluster to be run.
Also, I named the delimiter field {{-delim}} instead of {{-d}} since the former
is more consistent with existing param naming in {{HBaseStorage}]. Let me know
if you disagree.
FYI, this patch can also be found on git here:
https://github.com/billonahill/pig/tree/pig_1946
> HBaseStorage constructor syntax is error prone
> ----------------------------------------------
>
> Key: PIG-1946
> URL: https://issues.apache.org/jira/browse/PIG-1946
> Project: Pig
> Issue Type: Improvement
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.10
>
> Attachments: PIG-1946_1.patch, PIG-1946_2.patch
>
>
> Using {{HBaseStorage}} like so seems like a reasonable thing to do, but it
> will yield unexpected results:
> {code}
> STORE result INTO 'hbase://foo' USING
> org.apache.pig.backend.hadoop.hbase.HBaseStorage(
> 'info:first_name, info:last_name');
> {code}
> The problem us that a column named {{info:first_name,}} will be created, with
> the trailing comma included. I've had numerous developers get tripped up on
> this issue since everywhere else in Pig variables are separated by commas, so
> I propose we fix it.
> I propose we trim leading/trailing commas from column names, but I'm open to
> other ideas.
> Also should we accept column names that are comman-delimited without spaces?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
