[
https://issues.apache.org/jira/browse/PIG-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066275#comment-13066275
]
Thejas M Nair commented on PIG-2143:
------------------------------------
Thanks for adding the comprehensive documentation and fixing the incorrect old
one!
Review of PIG-2143.4.patch -
- In PigStorage.getSchema(..) , it should check for (!dontLoadSchema) for
deciding if the schema file should be read. (instead of (storeschema) ).
- A test case where pig loads schema with the default constructor will be
useful. One of the new test cases in the patch can be modified for this. I
think we need one for the -noschema as well.
- In javadoc for constructor PigStorage(String delimiter, String options), the
line about "-Dprop=value" can be removed as its not used right now.
- A nitpick - In the PigStorage class javadoc, I think 'An optional second
constructor' is a bit misleading. There are 3 constructors including default
one, and all 3 constructors are 'optional' :) . Maybe calling it 'Another
constructor' is better.
> Improvements for PigStorage
> ---------------------------
>
> Key: PIG-2143
> URL: https://issues.apache.org/jira/browse/PIG-2143
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2143.2.diff, PIG-2143.3.patch, PIG-2143.4.patch,
> PIG-2143.diff
>
>
> I'd like to propose that we allow for a greater degree of customization in
> PigStorage.
> An incomplete list features that we might want to add:
> - flag to tell it to overwrite existing output if it exists
> - flag to tell it to compress output using gzip|bzip|lzo (currently this can
> be achieved by setting the directory name to end in .gz or .bz2, which is a
> bit awkward)
> - flag to tell it to store the schema and header (perhaps by merging in
> PigStorageSchema work?)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
