[ 
https://issues.apache.org/jira/browse/PIG-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066287#comment-13066287
 ] 

Thejas M Nair commented on PIG-1904:
------------------------------------

The approach you are proposing for @NonDeterministic udf sounds good.

PIG-1904.1.patch looks good. Some comments -

I think it is better to retain the restriction that a split needs at least two 
output aliases. This will prevent split being used instead of filter, and from 
pig becoming perl ;).

Maybe, something like - 
split_clause : SPLIT rel INTO split_branch  (COMMA split_branch)* ( COMMA 
split_branch ) |( COMMA split_otherwise ))


In LogicalPlanBuilder.java, I think it is better to change the assertion to a 
if(root == null){throw exception;}, as assertions are not enabled by default.



> Default split destination
> -------------------------
>
>                 Key: PIG-1904
>                 URL: https://issues.apache.org/jira/browse/PIG-1904
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Daniel Dai
>              Labels: gsoc2011
>             Fix For: 0.10
>
>         Attachments: PIG-1904.1.patch
>
>
> "split" statement is better to have a default destination, eg:
> {code}
> SPLIT A INTO X IF f1<7, Y IF f2==5, Z IF (f3<6 OR f3>6), OTHER otherwise; -- 
> OTHERS has all tuples with f1>=7 && f2!=5 && f3==6
> {code}
> This is a candidate project for Google summer of code 2011. More information 
> about the program can be found at http://wiki.apache.org/pig/GSoc2011

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to