[ 
https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083081#comment-13083081
 ] 

Zhijie Shen commented on PIG-1429:
----------------------------------

Hi Daniel,

Thanks for your review, I've fixed 1, 3, 4. For 5, I'll add the comments and 
some end-to-end tests. For 2, if we want to stick to "boolean" as the name of 
Boolean Type, we'd better revise the grammar: changing from "bool" keyword to 
"boolean". Otherwise, Utils.getSchemaFromString() will be broken if the 
supplied schema string uses "bool". And the name used in Pig Latin commands 
should be consistent to that in the displayed plan/schema.

> Add Boolean Data Type to Pig
> ----------------------------
>
>                 Key: PIG-1429
>                 URL: https://issues.apache.org/jira/browse/PIG-1429
>             Project: Pig
>          Issue Type: New Feature
>          Components: data
>    Affects Versions: 0.7.0
>            Reporter: Russell Jurney
>            Assignee: Zhijie Shen
>              Labels: boolean, gsoc2011, pig, type
>         Attachments: PIG-1429_1.patch, PIG-1429_2.patch, PIG-1429_3.patch, 
> working_boolean.patch
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Pig needs a Boolean data type.  Pig-1097 is dependent on doing this.  
> I volunteer.  Is there anything beyond the work in src/org/apache/pig/data/ 
> plus unit tests to make this work?  
> This is a candidate project for Google summer of code 2011. More information 
> about the program can be found at http://wiki.apache.org/pig/GSoc2011

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to