----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1664/#review1684 -----------------------------------------------------------
trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/LimitAdjuster.java <https://reviews.apache.org/r/1664/#comment3838> please fix the indentation for the contents of this if block, and add {}s trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/LimitAdjuster.java <https://reviews.apache.org/r/1664/#comment3839> you keep having to cast it. Just add POStore storeOp = (POStore) mpLeaf; at the beginning of the block; it'll clean up the code. trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRUtil.java <https://reviews.apache.org/r/1664/#comment3841> please add documentation for Pig Developers indicating when and how to use the methods in this helper class. trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRUtil.java <https://reviews.apache.org/r/1664/#comment3840> will using this mess up projection push-down? - Dmitriy On 2011-08-29 23:34:23, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1664/ > ----------------------------------------------------------- > > (Updated 2011-08-29 23:34:23) > > > Review request for pig and Thejas Nair. > > > Summary > ------- > > See PIG-2237 > > > This addresses bug PIG-2237. > https://issues.apache.org/jira/browse/PIG-2237 > > > Diffs > ----- > > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/LimitAdjuster.java > PRE-CREATION > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRCompiler.java > 1162260 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRUtil.java > PRE-CREATION > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java > 1162260 > trunk/test/org/apache/pig/test/TestEvalPipeline2.java 1162260 > trunk/test/org/apache/pig/test/TestMRCompiler.java 1162260 > > Diff: https://reviews.apache.org/r/1664/diff > > > Testing > ------- > > Test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > Unit test: > all pass. > > > Thanks, > > Daniel > >
