[
https://issues.apache.org/jira/browse/PIG-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168689#comment-13168689
]
Dmitriy V. Ryaboy commented on PIG-2403:
----------------------------------------
I used the no-prefix option (otherwise it wouldn't be able to patch all those
other files).
Patch applies fine for my svn trunk checkout, too.. you are sure you are using
a clean environment?
{code}
[tw-mbp13-dryaboy pig-svn]$ svn up
At revision 1213916.
[tw-mbp13-dryaboy pig-svn]$ patch -p0 < ../pig-git/patches/PIG-2403.patch
patching file src/org/apache/pig/builtin/AlgebraicByteArrayMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicDoubleMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicFloatMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicIntMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicLongMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicMathBase.java
patching file src/org/apache/pig/builtin/DoubleAbs.java
patching file src/org/apache/pig/builtin/DoubleMax.java
patching file src/org/apache/pig/builtin/DoubleMin.java
patching file src/org/apache/pig/builtin/DoubleSum.java
patching file src/org/apache/pig/builtin/FloatMax.java
patching file src/org/apache/pig/builtin/FloatMin.java
patching file src/org/apache/pig/builtin/FloatSum.java
patching file src/org/apache/pig/builtin/IntMax.java
patching file src/org/apache/pig/builtin/IntMin.java
patching file src/org/apache/pig/builtin/IntSum.java
patching file src/org/apache/pig/builtin/LongMax.java
patching file src/org/apache/pig/builtin/LongMin.java
patching file src/org/apache/pig/builtin/LongSum.java
patching file src/org/apache/pig/builtin/MAX.java
patching file src/org/apache/pig/builtin/MIN.java
patching file src/org/apache/pig/builtin/SUM.java
{code}
> Reduce code duplication in SUM, MAX, MIN udfs
> ---------------------------------------------
>
> Key: PIG-2403
> URL: https://issues.apache.org/jira/browse/PIG-2403
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.11
>
> Attachments: PIG-2403.patch
>
>
> The current type-specific implementations of Max, Min, and Sum have a lot of
> duplicated code. We can reduce this significantly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
