[
https://issues.apache.org/jira/browse/PIG-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174410#comment-13174410
]
Jonathan Coveney commented on PIG-2443:
---------------------------------------
That sounds fine. In the case of numeric, I think we need to think about when
you want it to return true.
1. Should it only return true for valid Int, Long, Double, or Float values?
Your example would return true for
111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111,
though this is way too large to be any of the above!
2. A Java double can take the form 2.22e308, or whathave you. You said that a
regex is faster than a Double, but how much faster. You can build in all the
rules, but eventually you're just reimplementing the logic of parseDouble.
> [Piggybank] Add UDFs to check if a String is an Integer And if a String is
> Numeric
> ----------------------------------------------------------------------------------
>
> Key: PIG-2443
> URL: https://issues.apache.org/jira/browse/PIG-2443
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
> Reporter: Prashant Kommireddi
> Assignee: Prashant Kommireddi
> Attachments: isIntNumeric.patch, isIntNumeric.patch
>
>
> UDF that could be used to check if a String is numeric (or an Integer).
> Several tools such as Splunk, AbInitio have this UDF built-in and companies
> making an effort to move to Hadoop/Pig could use this.
> Use Case:
> In raw logs there are certain filters/conditions applied based on whether a
> particular field/value is numeric or not. For eg, SPLIT A INTO CATEGORY1 IF
> IsInt($0), CATEGORY2 IF !IsInt($0);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira