[ 
https://issues.apache.org/jira/browse/PIG-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184644#comment-13184644
 ] 

Daniel Dai commented on PIG-2326:
---------------------------------

There are seems several threads in our discussion. I want to make sure we 
understand clearly:
1. The patch itself. I am totally fine with it if tests pass

2. For the reason why we check existence hadoop-site.xml in mapreduce mode
Yes, remove this check will simplify MiniCluster test. However, I only want to 
solve one problem: If user run pig in mapreduce mode, but he forget putting 
config file in classpath, pig will remind user rather than enter into an 
agnostic mode. By agnostic mode, I mean some Pig operator run, but some are not 
(like order by).
                
> Pig minicluster tests can not be run from eclipse
> -------------------------------------------------
>
>                 Key: PIG-2326
>                 URL: https://issues.apache.org/jira/browse/PIG-2326
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Julien Le Dem
>            Assignee: Julien Le Dem
>            Priority: Minor
>         Attachments: PIG-2326.patch, PIG-2326_a.patch, PIG-2326_b.patch
>
>
> Some of the setup of the minicluster tests are in the ant config hence they 
> don't run in eclipse.
> In particular:
> System.setProperty("hadoop.log.dir", "build/test/logs");
> hadoop-site.xml in the classpath

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to