[ 
https://issues.apache.org/jira/browse/PIG-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209638#comment-13209638
 ] 

Daniel Dai commented on PIG-2530:
---------------------------------

Unit test pass. test-patch:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 
warning messages.
     [exec] 
     [exec]     +1 javac. 
     [exec]  The applied patch does not increase the total number of javac 
compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 529 release 
audit warnings (more than the trunk's current 526 warnings).

javac and release audit warning are unrelated.

Patch is ready to review.
                
> Reusing alias name in nested foreach causes incorrect results
> -------------------------------------------------------------
>
>                 Key: PIG-2530
>                 URL: https://issues.apache.org/jira/browse/PIG-2530
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.2, 0.10
>            Reporter: Vivek Padmanabhan
>            Priority: Critical
>         Attachments: PIG-2530-0.patch, PIG-2530-1.patch, PIG-2530-2.patch
>
>
> The below script results in incorrect output for Pig 0.10 but runs fine with 
> Pig 0.8,
> {code}
> input.txt
> 1     4
> 1     3
> 2     3
> 2     4
> {code}
> {code}
> a = load 'input.txt' as (v1:int, v2:int);
> b = group a by v1;
> c = foreach b { x = a; x = order x by v2 asc; generate flatten(x); }
> store c into 'c1';
> {code}
> Output from Pig 0.10
> --------------------
> 1       4
> 1       3
> 2       3
> 2       4
> Looking at the explain, it seems like the sorting is entirely missed out. 
> The script produces correct results if I change the alias name ie;
> c = foreach b { x = a; x1 = order x by v2 asc; generate flatten(x1); }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to