[ https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225781#comment-13225781 ]
Daniel Dai commented on PIG-2551: --------------------------------- Generally it looks good. In addition to Julien's comment, it also needs header and javadoc. We need to provide guidance for user to use both functions. From the chain algebraic->accumulate->evalfunc, once user implements a functionality, he automatically get the functionality on the right side. Also need to document from performance point of view, this is not preferred implementation since the simulation would make extra function calls. > Create an AlgebraicEvalFunc and AccumulatorEvalFunc abstract class which > gives you the lower levels for free > ------------------------------------------------------------------------------------------------------------ > > Key: PIG-2551 > URL: https://issues.apache.org/jira/browse/PIG-2551 > Project: Pig > Issue Type: Improvement > Reporter: Jonathan Coveney > Assignee: Jonathan Coveney > Priority: Minor > Fix For: 0.11 > > Attachments: PIG-2551-0.patch > > > This is more of a win for the Algebraic interface than the Accumulator > interface, but the idea is that if you implement the Algebraic interface, you > should get Accumulator/EvalFunc for free, and if you implement Accumulator, > you should get EvalFunc for free. The win of this is that in cases such as > JRuby, you don't have to muck around doing this yourself...you have them > implement the algebraic portion, and the rest comes free (that is where this > came out of, but I feel like it is generally useful enough). > The next piece of work I'd like to do is making an easier to implement way to > make Algebraic UDFs, but then again, my to do is huge :) Would love thoughts > on this. If it doesn't make it into Pig, it's still going to come in the > JRuby stuff, so I thought it'd at least be worth having it separate, tested, > and available to everyone. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira