[ https://issues.apache.org/jira/browse/PIG-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237390#comment-13237390 ]
jirapos...@reviews.apache.org commented on PIG-2317: ---------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4091/ ----------------------------------------------------------- (Updated 2012-03-24 01:33:02.389407) Review request for pig, Julien Le Dem and Alan Gates. Changes ------- I incorporated a ton of Julien's comments, added a lot of javadocs, and rounded out the completeness. More fully featured and tastier than ever. Summary ------- This is the reviewboard for the following: https://issues.apache.org/jira/browse/PIG-2317 This addresses bug PIG-2317. https://issues.apache.org/jira/browse/PIG-2317 Diffs (updated) ----- trunk/bin/pig 1304676 trunk/build.xml 1304676 trunk/ivy.xml 1304676 trunk/ivy/libraries.properties 1304676 trunk/src/PigudfService.java PRE-CREATION trunk/src/main/jruby/pigudf.rb PRE-CREATION trunk/src/org/apache/pig/AccumulatorEvalFunc.java PRE-CREATION trunk/src/org/apache/pig/AlgebraicEvalFunc.java PRE-CREATION trunk/src/org/apache/pig/scripting/ScriptEngine.java 1304676 trunk/src/org/apache/pig/scripting/jruby/JrubyAccumulatorEvalFunc.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/JrubyAlgebraicEvalFunc.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/JrubyEvalFunc.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/JrubyFilterFunc.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/JrubyScriptEngine.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/PigJrubyLibrary.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/RubyDataBag.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/RubyDataByteArray.java PRE-CREATION trunk/src/org/apache/pig/scripting/jruby/RubySchema.java PRE-CREATION trunk/src/org/apache/pig/tools/counters/PigCounterHelper.java PRE-CREATION trunk/test/e2e/pig/build.xml 1304676 trunk/test/e2e/pig/conf/default.conf 1304676 trunk/test/e2e/pig/drivers/TestDriverPig.pm 1304676 trunk/test/e2e/pig/tests/nightly.conf 1304676 trunk/test/e2e/pig/udfs/ruby/morerubyudfs.rb PRE-CREATION trunk/test/e2e/pig/udfs/ruby/scriptingudfs.rb PRE-CREATION trunk/test/org/apache/pig/test/TestUDF.java 1294756 trunk/test/org/apache/pig/test/utils/HelperEvalFuncUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/4091/diff Testing ------- e2e tests can be run as follows: ant -Dharness.hadoop.home=<path_to_hadoop> -Dharness.old.pig=<path_to_old_pig> test-e2e-deploy-local ant -Dharness.hadoop.home=<path_to_hadoop> -Dharness.old.pig=<path_to_old_pig> -Dtests.to.run="-t RubyUDFs" test-e2e-local Thanks, Jonathan > Ruby/Jruby UDFs > --------------- > > Key: PIG-2317 > URL: https://issues.apache.org/jira/browse/PIG-2317 > Project: Pig > Issue Type: New Feature > Reporter: Jacob Perkins > Assignee: Jonathan Coveney > Priority: Minor > Attachments: PIG-2317-10.patch, PIG-2317-8.patch, > PIG-2317-8_plus.patch, PIG-2317-9.patch, PigUdf.rb, PigUdf.rb, > jruby_scripting.patch, jruby_scripting_2_real.patch, jruby_scripting_3.patch, > jruby_scripting_4.patch, jruby_scripting_5.patch, jruby_scripting_6.patch, > jruby_scripting_7.patch, pigjruby.rb, pigjruby.rb, pigjruby.rb, pigudf.rb > > > It should be possible to write UDFs in Ruby. These UDFs will be registered in > the same way as python and javascript UDFs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira