I am fine with it. Please also include the following tiny patch to fix hadoop 23 build after the patch.
--- pig/trunk/ivy.xml (original) +++ pig/trunk/ivy.xml Thu Apr 26 21:11:36 2012 @@ -178,7 +178,7 @@ <dependency org="net.java.dev.javacc" name="javacc" rev="${javacc.version}" conf="compile->master"/> <dependency org="junit" name="junit" rev="${junit.version}" - conf="test->default"/> + conf="compile->master"/> <dependency org="com.google.code.p.arat" name="rat-lib" rev="${rats-lib.version}" conf="releaseaudit->default"/> <dependency org="org.codehaus.jackson" name="jackson-mapper-asl" rev="${jackson.version}" Daniel On Thu, Apr 26, 2012 at 2:07 PM, Julien Le Dem <jul...@twitter.com> wrote: > I'm planning to commit this in 0.10 branch as well > The patch has only new files so it will apply cleanly. > Any objection? > Julien > > > On Apr 26, 2012, at 1:30 PM, Julien Le Dem (JIRA) wrote: > >> >> [ >> https://issues.apache.org/jira/browse/PIG-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Julien Le Dem resolved PIG-2650. >> -------------------------------- >> >> Resolution: Fixed >> Fix Version/s: 0.11 >> >>> Convenience mock Loader and Storer to simplify unit testing of Pig scripts >>> -------------------------------------------------------------------------- >>> >>> Key: PIG-2650 >>> URL: https://issues.apache.org/jira/browse/PIG-2650 >>> Project: Pig >>> Issue Type: New Feature >>> Reporter: Julien Le Dem >>> Assignee: Julien Le Dem >>> Fix For: 0.11 >>> >>> Attachments: PIG-2650-a.patch, PIG-2650-b.patch, PIG-2650-c.patch, >>> PIG-2650.patch >>> >>> >>> A test would look as follows: >>> {code} >>> PigServer pigServer = new PigServer(ExecType.LOCAL); >>> TupleFactory tf = TupleFactory.getInstance(); >>> Data data = Storage.resetData(pigServer.getPigContext()); >>> data.set("foo", Arrays.asList( >>> tf.newTuple("a"), >>> tf.newTuple("b"), >>> tf.newTuple("c") >>> )); >>> pigServer.registerQuery("A = LOAD 'foo' USING mock.Storage();"); >>> // some complex script to test >>> pigServer.registerQuery("STORE A INTO 'bar' USING mock.Storage();"); >>> Iterator<Tuple> out = data.get("bar").iterator(); >>> assertEquals("a", out.next().get(0)); >>> assertEquals("b", out.next().get(0)); >>> assertEquals("c", out.next().get(0)); >>> {code} >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> >