The reason in my case is that I started implementing a non-trivial Tuple
implementation, and it feels really janky to me to have this sort of tribal
knowledge that "oh, it's ok to do nothing in this method, or it's ok to
return null here." It just muddies up the Tuple contract... should my
implementation use it? Shouldn't it? If possible I think the interface
should be as lean as it can, but, to quote The Dude, "that's just
like...your opinion, man."

But in general, I think we should put work into cleaning up all the
interfaces wherever possible. Assuming pig continues to gain popularity, a
huge barrier to entry is confusing interfaces (EvalFunc and especially
Load/StoreFunc are the worst offenders).

2012/5/30 Alan Gates <ga...@hortonworks.com>

> Officially our policy is deprecated methods can be removed after they have
> been deprecated for at least one release.  Unofficially we've tended to
> follow the path of least resistance and only remove deprecated things when
> we had a reason.  This approach seems reasonable to me, as it inflicts the
> least pain on users.
>
> So I'm fine with removing these, if there's a reason.
>
> Alan.
>
> On May 30, 2012, at 5:29 PM, Jonathan Coveney wrote:
>
> > I'm pinging dev directly because I am afraid this won't get any eyes
> > otherwise. Also, because there is a bigger issue here: what should our
> > policy on removing deprecated methods be? reference(Tuple), I'm looking
> at
> > you.
> >
> > ---------- Forwarded message ----------
> > From: Julien Le Dem (JIRA) <j...@apache.org>
> > Date: 2012/5/30
> > Subject: [jira] [Commented] (PIG-2732) Let's get rid of the deprecated
> > Tuple methods
> > To: pig-...@hadoop.apache.org
> >
> >
> >
> >   [
> >
> https://issues.apache.org/jira/browse/PIG-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286205#comment-13286205
> ]
> >
> > Julien Le Dem commented on PIG-2732:
> > ------------------------------------
> >
> > +1 it's been deprecated in the previous version of Pig. Nothing uses it
> > inside Pig.
> > Let's remove it.
> >
> >
> >> Let's get rid of the deprecated Tuple methods
> >> ---------------------------------------------
> >>
> >>                Key: PIG-2732
> >>                URL: https://issues.apache.org/jira/browse/PIG-2732
> >>            Project: Pig
> >>         Issue Type: Improvement
> >>           Reporter: Jonathan Coveney
> >>           Assignee: Jonathan Coveney
> >>            Fix For: 0.11
> >>
> >>        Attachments: PIG-2732-0.patch
> >>
> >>
> >> In my favorite comment ever, this is the comment on isNull and setNull
> >> {code}
> >>    /**
> >>     * This is an unsupported method.
> >>     * It never really worked. Don't use it!
> >>     * @param isNull (but it will be ignored)
> >>     */
> >> {code}
> >> Simply delightful. Let's get rid of it!
> >> And let's @deprecate reference, which never really was used to begin
> with
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators:
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>

Reply via email to