[ https://issues.apache.org/jira/browse/PIG-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401664#comment-13401664 ]
Harsh J commented on PIG-2746: ------------------------------ Daniel/Others, Does the provided test suffice? Is there anything else you'd like me to address to get this in? Do let me know! > Pig doesn't detect all forms of compression extensions properly > --------------------------------------------------------------- > > Key: PIG-2746 > URL: https://issues.apache.org/jira/browse/PIG-2746 > Project: Pig > Issue Type: Bug > Affects Versions: 0.8.1 > Reporter: Harsh J > Assignee: Harsh J > Attachments: PIG-2746.patch, PIG-2746.patch, PIG-2746.patch > > > The PigStorage has the following snippet. > {code} > private void setCompression(Path path, Job job) { > String location=path.getName(); > if (location.endsWith(".bz2") || location.endsWith(".bz")) { > FileOutputFormat.setCompressOutput(job, true); > FileOutputFormat.setOutputCompressorClass(job, BZip2Codec.class); > } else if (location.endsWith(".gz")) { > FileOutputFormat.setCompressOutput(job, true); > FileOutputFormat.setOutputCompressorClass(job, GzipCodec.class); > } else { > FileOutputFormat.setCompressOutput( job, false); > } > } > {code} > This limits it to only work with STORE filenames provided as 'output.gz' or > 'output.bz2' and for the rest (like LZO) one has to specify codecs and > manually enable compression. > Ideally Pig can rely on Hadoop's extension-to-codec detector instead of > having this ladder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira