[ 
https://issues.apache.org/jira/browse/PIG-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated PIG-1314:
-----------------------------

    Attachment: PIG-1314-4.patch

Hi Thejas,

Here's my latest patch. Compared to the last one, there are the following 
modifications:

1. I've modified the code according to many of review comments.

2. I've added many test cases, but some are still missing. I'll add more in the 
following days.

3. I've fixed some bugs while running the newly added test cases.

There's still some issues related to timezone I need to discuss with you:

1. You've mentioned that we need to propagate the timezone from the client to 
backend, where the udfs get executed. How the timezone should be propagated to 
the backend, which I assume the machine that runs the code? Previously I made 
the timezone setting in pig.properties, which will be loaded when PigServer 
runs, such that the default timezone will be set. Consequently, if a datetime 
object is created without specifying the timezone, the default one will be 
used. However, do you mean some other way?

2. According to our previous discussion, ToDate() can take different type of 
timezone input, either location or UTC offset. However, two timezones of the 
two different types may be treated not equal even when the offset is same. For 
example, new DateTime(0L, DateTimeZone.forID("asia/singapore")) and new 
DateTime(0L, DateTimeZone.forID("+08:00")) are not equal. As we previously 
chose the UTC offset to be the basic timezone representation, I convert the 
location-based timezone to the utc-offset one and only use utc-offset style 
internally. Therefore, the aforementioned two equal datetime objects will not 
be mis-treated.

Regards,
Zhijie
                
> Add DateTime Support to Pig
> ---------------------------
>
>                 Key: PIG-1314
>                 URL: https://issues.apache.org/jira/browse/PIG-1314
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.7.0
>            Reporter: Russell Jurney
>            Assignee: Zhijie Shen
>              Labels: gsoc2012
>         Attachments: PIG-1314-1.patch, PIG-1314-2.patch, PIG-1314-3.patch, 
> PIG-1314-4.patch, joda_vs_builtin.zip
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Hadoop/Pig are primarily used to parse log data, and most logs have a 
> timestamp component.  Therefore Pig should support dates as a primitive.
> Can someone familiar with adding types to pig comment on how hard this is?  
> We're looking at doing this, rather than use UDFs.  Is this a patch that 
> would be accepted?
> This is a candidate project for Google summer of code 2012. More information 
> about the program can be found at 
> https://cwiki.apache.org/confluence/display/PIG/GSoc2012

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to