[ 
https://issues.apache.org/jira/browse/PIG-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433315#comment-13433315
 ] 

Dmitriy V. Ryaboy commented on PIG-2866:
----------------------------------------

2 comments:
1) having 2 variables, one named fname and the other named filename is 
confusing. Please rename.

2) For the test, you are creating an actual temp file. It's better to use 
mock.Storage, we should encourage use of that utility throughout tests.
                
> PigServer fails with macros without a script file
> -------------------------------------------------
>
>                 Key: PIG-2866
>                 URL: https://issues.apache.org/jira/browse/PIG-2866
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Bill Graham
>            Assignee: Bill Graham
>             Fix For: 0.11
>
>         Attachments: PIG-2866.1.patch
>
>
> Making a call to {{PigServer.registerQuery}} with an {{InputStream}} will 
> fail if the script contains a macro. This is because 
> {{QueryParserDriver.makeMacroDef}} requires a filename. 
> {{QueryParserDriver.makeMacroDef}} should be changed to not assume that the 
> script input is from a file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to