[
https://issues.apache.org/jira/browse/PIG-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433396#comment-13433396
]
Alan Gates commented on PIG-1891:
---------------------------------
I don't see where cleanupOnSuccess is invoked by the system, so I assume the
purpose of this patch is to propose the change to the interface, not to
actually implement the functionality yet. On this assumption, the patch looks
ok except for one issue: StoreFunc is a public stable class. You can't change
the name of publicly available methods. Changing cleanupOnFailure to
cleanupImpl breaks backwards compatibility.
> Enable StoreFunc to make intelligent decision based on job success or failure
> -----------------------------------------------------------------------------
>
> Key: PIG-1891
> URL: https://issues.apache.org/jira/browse/PIG-1891
> Project: Pig
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Alex Rovner
> Priority: Minor
> Labels: patch
> Attachments: PIG-1891-1.patch
>
>
> We are in the process of using PIG for various data processing and component
> integration. Here is where we feel pig storage funcs lack:
> They are not aware if the over all job has succeeded. This creates a problem
> for storage funcs which needs to "upload" results into another system:
> DB, FTP, another file system etc.
> I looked at the DBStorage in the piggybank
> (http://svn.apache.org/viewvc/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/DBStorage.java?view=markup)
> and what I see is essentially a mechanism which for each task does the
> following:
> 1. Creates a recordwriter (in this case open connection to db)
> 2. Open transaction.
> 3. Writes records into a batch
> 4. Executes commit or rollback depending if the task was successful.
> While this aproach works great on a task level, it does not work at all on a
> job level.
> If certain tasks will succeed but over job will fail, partial records are
> going to get uploaded into the DB.
> Any ideas on the workaround?
> Our current workaround is fairly ugly: We created a java wrapper that
> launches pig jobs and then uploads to DB's once pig's job is successful.
> While the approach works, it's not really integrated into pig.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
