Committed today, thanks both. D
On Sat, Aug 18, 2012 at 9:26 AM, Віталій Тимчишин <[email protected]> wrote: > I understand. I did add patch to PIG-2556 at the same time. Patch is > generated with git, if it's not OK I can try to redo it. > See > https://issues.apache.org/jira/secure/attachment/12541355/CSVExcelProblems-2.patch > > 2012/8/17 Jonathan Coveney <[email protected]> > >> Howdy Vitalii, >> >> We actually can't merge in pull requests via github. It's purely a mirror. >> >> The version control of truth is subversion, and you need to submit a patch >> to a ticket via JIRA. >> >> Thanks for your submission, but alas, github isn't the way to do it yet. >> This has it's good and bade sides, but hope it will not discourage you from >> contributing >> Jon >> >> 2012/8/17 tivv <[email protected]> >> >>> GitHub user tivv opened a pull request: >>> >>> https://github.com/apache/pig/pull/6 >>> >>> Fix newline right after quote >>> >>> PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly >>> in multiline mode >>> >>> You can merge this pull request into a Git repository by running: >>> >>> $ git pull https://github.com/tivv/pig CSVExcelNewLineBug >>> >>> Alternatively you can review and apply these changes as the patch at: >>> >>> https://github.com/apache/pig/pull/6.patch >>> >>> ---- >>> commit c2c077c30d3934577425f351eb097778047ad7b2 >>> Author: Vitalii Tymchyshyn <[email protected]> >>> Date: 2012-08-17T05:17:46-07:00 >>> >>> Fix newline right after quote >>> >>> ---- >>> >>> >> > > > -- > Best regards, > Vitalii Tymchyshyn
